Fixed issue with "url(""); ... any other css code .. url("file.jpg"); in one line #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….svg");" CSS code
….svg");" CSS code
matthiasmullie
force-pushed
the
master
branch
5 times, most recently
from
85ee174 to
227f190
Compare
Contributor
|
please check for both ["] & ['] ; |
Author
|
Done |
| protected function importFiles($source, $content) | ||
| { | ||
| $regex = '/url\((["\']?)(.+?)\\1\)/i'; | ||
| $regex = '/url\((["\']?)([^"\']+?)\\1\)/i'; |
Owner
There was a problem hiding this comment.
This will be a problem when a quote is encountered inside the url.
I think changing the regex to '/url\((["\']?)(.*?)\\1\)/i'; instead of '/url\((["\']?)(.+?)\\1\)/i'; (note the * instead of +, which would allow an empty url value) should also work.
Could you confirm whether that fixes your issue, and resubmit if so?
Thanks!
Contributor
There was a problem hiding this comment.
an empty URL should not get parsed
matthiasmullie
force-pushed
the
master
branch
3 times, most recently
from
949e01d to
51d1aa4
Compare
matthiasmullie
force-pushed
the
master
branch
2 times, most recently
from
9ddadb8 to
4c4ecee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CSS files with
url("")and any other url() within one line, the second file was ignored.See https://regex101.com/r/IkhmxT/2
Sure, "url()" is invalid CSS syntax, but this should be ignored and other URLs in the same line should get handled correctly.