Skip to content

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Nov 24, 2025

Description

Fix conda-forge/mamba-feedstock#362.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the release::bug_fixes For PRs fixing bugs label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.48%. Comparing base (5634187) to head (a1bdc66).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/download/downloader.cpp 58.82% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4101   +/-   ##
=======================================
  Coverage   63.47%   63.48%           
=======================================
  Files         315      315           
  Lines       38632    38644   +12     
  Branches     2966     2967    +1     
=======================================
+ Hits        24521    24532   +11     
- Misses      14042    14043    +1     
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan jjerphan force-pushed the fix/ca-certificate-local-env branch 3 times, most recently from 0cde832 to 091170f Compare November 24, 2025 16:15
@jjerphan jjerphan marked this pull request as ready for review November 24, 2025 16:16
@jjerphan jjerphan force-pushed the fix/ca-certificate-local-env branch 5 times, most recently from 97bac5d to 6750848 Compare November 25, 2025 10:21
@jjerphan jjerphan force-pushed the fix/ca-certificate-local-env branch 2 times, most recently from 5978806 to 90a1924 Compare November 27, 2025 16:53
@jjerphan jjerphan force-pushed the fix/ca-certificate-local-env branch 4 times, most recently from bd6cc07 to 30ede81 Compare November 28, 2025 09:14
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan merged commit 4a43769 into mamba-org:main Dec 2, 2025
59 of 65 checks passed
@jjerphan jjerphan deleted the fix/ca-certificate-local-env branch December 2, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why does mamba need external ca-certificates, while conda does not?

2 participants