Clean up macro names and static functions #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaeckel
force-pushed
the
pr/macro-names-cleanup
branch
from
6d1d34d to
659d7f8
Compare
sjaeckel
force-pushed
the
pr/macro-names-cleanup
branch
5 times, most recently
from
0a1c161 to
ff642bf
Compare
sjaeckel
force-pushed
the
pr/macro-names-cleanup
branch
from
ff642bf to
c5d7bfb
Compare
This fixes #540
karel-m
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the names of macros and static functions as it was pointed out already multiple times that technically their names are UB