Skip to content

Fix: get_version.go returns wrong version when multiple entries exist #21971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: get_version.go returns wrong version when multiple entries exist #21971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion hack/update/get_version/get_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,15 @@ func main() {
if err != nil {
log.Fatalf("failed to read file: %v", err)
}
submatches := re.FindSubmatch(data)

// this handles cases where multiple versions exist (e.g., old and new versions in go.mod)
allMatches := re.FindAllSubmatch(data, -1)
if len(allMatches) == 0 {
log.Fatalf("no matches found")
}

// Take the last match (most recent version)
submatches := allMatches[len(allMatches)-1]
if len(submatches) < 2 {
log.Fatalf("less than 2 submatches found")
}
Expand Down
Loading