Skip to content

wip: Fix image loading with podman driver #21932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+10 −13
Closed

wip: Fix image loading with podman driver #21932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions pkg/minikube/node/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,22 +164,19 @@ func beginDownloadKicBaseImage(g *errgroup.Group, cc *config.ClusterConfig, down
err = download.ImageToCache(img)
if err == nil {
klog.Infof("successfully saved %s as a tarball", img)
}
if downloadOnly && err == nil {
return nil
}

if cc.Driver == driver.Podman {
return fmt.Errorf("not yet implemented, see issue #8426")
}
if driver.IsDocker(cc.Driver) && err == nil {
klog.Infof("Loading %s from local cache", img)
if finalImg, err = download.CacheToDaemon(img); err == nil {
klog.Infof("successfully loaded and using %s from cached tarball", img)
if downloadOnly {
return nil
}

if driver.IsKIC(cc.Driver) {
klog.Infof("Loading %s from local cache", img)
if finalImg, err = download.CacheToDaemon(img); err == nil {
Copy link
Collaborator

@afbjorklund afbjorklund Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function needs to add support for podman, currently it only supports docker...

The easiest is probably forking a call to exec, had do to that anyway (for the digest)

Copy link
Contributor Author

@obnoxxx obnoxxx Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afbjorklund wrote:

This function needs to add support for podman, currently it only supports docker...

The easiest is probably forking a call to exec, had do to that anyway (for the digest)

good point, but the ToDaemon part of the function's name does not really apply to podman, right?

Copy link
Collaborator

@afbjorklund afbjorklund Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can either rename the function to more a more generic name, or make another one just for Podman.

Calling it "daemon" in the first place, was focusing on the wrong part of "Docker daemon" anyway...

daemon.Write (pkg/v1/daemon)

github.com/docker/docker/client

klog.Infof("successfully loaded and using %s from cached tarball", img)
return nil
}
}
klog.Infof("failed to download %s, will try fallback image if available: %v", img, err)
}
klog.Infof("failed to download %s, will try fallback image if available: %v", img, err)
}
// second if we failed to download any fallback image
// that means probably all registries are blocked by network issues
Expand Down