-
Notifications
You must be signed in to change notification settings - Fork 5.1k
feat: Add custom CRI-O storage paths with automatic bind mount #21903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vtri950 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Welcome @vtri950! |
|
Hi @vtri950. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
medyagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtri950
to help me undrestand this, can you provide an example of running this new feature ? and how does this help crio users?
|
@medyagh absolutely! it starts with this podman-desktop/podman-desktop#2866 so @benoitf and @afbjorklund came up with soln using minikube to do that but this required to run the cluster on kicbase image and to avoid that they openend this issue and my pr fixes that i have tested it on my wsl(ubuntu) for podman with rootless and in windows with a podman vm(rootful) and it works as expected you can build your images with podman and directly run your container inside minikubbe cluster without having that extra manual load step |
Add support for custom CRI-O storage paths with automatic bind mounts
Implements automatic sharing of Podman host images with CRI-O in minikube
by allowing users to specify custom storage paths that are automatically
bind-mounted into the container.
This enhancement adds two new flags:
When these flags are used with KIC drivers (Podman/Docker) and CRI-O runtime,
the specified directories are automatically:
This eliminates the need for manual kicbase modifications or image loading
when using Podman as the driver with CRI-O runtime.
Fixes #17415