Skip to content

Conversation

@vtri950
Copy link

@vtri950 vtri950 commented Nov 16, 2025

Add support for custom CRI-O storage paths with automatic bind mounts

Implements automatic sharing of Podman host images with CRI-O in minikube
by allowing users to specify custom storage paths that are automatically
bind-mounted into the container.

This enhancement adds two new flags:

  • --container-storage-root: Specifies custom CRI-O storage root path
  • --container-storage-runroot: Specifies custom CRI-O runtime root path

When these flags are used with KIC drivers (Podman/Docker) and CRI-O runtime,
the specified directories are automatically:

  1. Bind-mounted from host to container at the same paths
  2. Configured in CRI-O's configuration file
  3. Used by CRI-O for image storage

This eliminates the need for manual kicbase modifications or image loading
when using Podman as the driver with CRI-O runtime.

Fixes #17415

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vtri950
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from medyagh November 16, 2025 09:27
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 16, 2025

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @vtri950!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vtri950. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtri950
to help me undrestand this, can you provide an example of running this new feature ? and how does this help crio users?

@vtri950
Copy link
Author

vtri950 commented Nov 22, 2025

@medyagh absolutely!

it starts with this podman-desktop/podman-desktop#2866
the current setup of podman with kind has a manual step of loading images in kind container after podman builds them
we wanted to automate that process

so @benoitf and @afbjorklund came up with soln using minikube to do that
https://gist.github.com/benoitf/3e45effb48e27791282eb227410f5950

but this required to run the cluster on kicbase image and to avoid that they openend this issue
#17415

and my pr fixes that

i have tested it on my wsl(ubuntu) for podman with rootless and in windows with a podman vm(rootful) and it works as expected

you can build your images with podman and directly run your container inside minikubbe cluster without having that extra manual load step

@vtri950 vtri950 requested a review from medyagh November 24, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to reuse podman images of the podman machine when using podman driver

5 participants