Skip to content

Remove deprecated e2e tests and related files #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

Remove deprecated e2e tests and related files #3011

merged 1 commit into from
Dec 2, 2025

Conversation

@rino-gaelico
Copy link
Contributor

@rino-gaelico rino-gaelico commented Nov 12, 2025

The new images are now psc-e2e-test neg-e2e-test ingress-controller-e2e-test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2025

Hi @rino-gaelico. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 12, 2025
@rino-gaelico
Copy link
Contributor Author

rino-gaelico commented Nov 12, 2025

/cc @swetharepakula

swetharepakula
swetharepakula reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 12, 2025
@rino-gaelico
Copy link
Contributor Author

rino-gaelico commented Nov 12, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2025

@rino-gaelico: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swetharepakula
Copy link
Member

swetharepakula commented Nov 13, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2025
@rino-gaelico
Copy link
Contributor Author

rino-gaelico commented Nov 13, 2025

/retest

swetharepakula
swetharepakula reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the second two commits and rearrange the order? It makes it so that we build correctly at every commit

@rino-gaelico rino-gaelico force-pushed the deprecate-cmd/e2e-test branch from 5b0ca34 to 1eaad5b Compare November 13, 2025 23:21
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025
swetharepakula
swetharepakula reviewed Dec 2, 2025
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@rino-gaelico rino-gaelico force-pushed the deprecate-cmd/e2e-test branch from 1eaad5b to b01c49c Compare December 2, 2025 19:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@rino-gaelico
Remove deprecated e2e tests and related files; new images are now psc…
64e694a 
…-e2e-test neg-e2e-test ingress-controller-e2e-test
@rino-gaelico rino-gaelico force-pushed the deprecate-cmd/e2e-test branch from 7e59d6c to 64e694a Compare December 2, 2025 20:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025
swetharepakula
swetharepakula reviewed Dec 2, 2025
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rino-gaelico, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6067f6 into kubernetes:master Dec 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@sawsa307 sawsa307 Awaiting requested review from sawsa307

1 more reviewer

@swetharepakula swetharepakula swetharepakula left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@swetharepakula swetharepakula

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rino-gaelico @k8s-ci-robot @swetharepakula