-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ Allow overriding image name in clusterctl config #13014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Allow overriding image name in clusterctl config #13014
Conversation
Signed-off-by: Alexandr Demicev <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area clusterctl |
|
Thanks @alexander-demicev. /lgtm |
|
LGTM label has been added. Git tree hash: f0443ca25466e6ce217493cb8df62c259ca89dff
|
| return f.WithImageMetaWithName(component, repository, "", tag) | ||
| } | ||
|
|
||
| func (f *FakeReader) WithImageMetaWithName(component, repository, name, tag string) *FakeReader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems better to me to change the signature of the WithImageMeta function, even if it will result in more changes in various locations. the reason why i'm suggesting this is because Name is essentially part of the ImageMeta.
What this PR does / why we need it:
This PR adds a name override option for the
clusterctlconfig:We have use-case where using
clusterctlconfig is the best option to override CAPI image name for some air-gapped scenarios where image is retagged with a slightly different name.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area clusterctl