Skip to content

📖 Document providers that support deletion single MachinePool Machines #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

📖 Document providers that support deletion single MachinePool Machines #12872

merged 1 commit into from
Nov 26, 2025
+10 −8

Conversation

@AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 17, 2025

What this PR does / why we need it:

Follow-up for #12797, as suggested by @richardcase

/area machinepool

@k8s-ci-robot k8s-ci-robot added area/machinepool Issues or PRs related to machinepools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2025
@AndiDog AndiDog mentioned this pull request Oct 17, 2025
Merged
fabriziopandini
fabriziopandini reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 17, 2025

LGTM label has been added.

Git tree hash: 531bcbbb06b10af71fb50b14c08dccfa1cbb43cd

fabriziopandini
fabriziopandini reviewed Oct 17, 2025
View reviewed changes
@AndiDog AndiDog changed the title Document providers that support deletion single MachinePool Machines 📖 Document providers that support deletion single MachinePool Machines Oct 21, 2025
@AndiDog AndiDog force-pushed the mp-machines-support-docs branch from fed69a5 to 8b335bb Compare October 27, 2025 12:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2025
fabriziopandini
fabriziopandini reviewed Nov 11, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge after rebase

@AndiDog AndiDog force-pushed the mp-machines-support-docs branch from 8b335bb to 7d14a43 Compare November 20, 2025 05:47
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2025
@AndiDog
Copy link
Contributor Author

AndiDog commented Nov 20, 2025

@fabriziopandini I rebased

sbueringer
sbueringer reviewed Nov 20, 2025
View reviewed changes
docs/book/src/tasks/experimental-features/machine-pools.md Outdated
| [OCI](https://oracle.github.io/cluster-api-provider-oci/managed/managedcluster.html) | `OCIManagedMachinePool`<br> `OCIMachinePool` | Implemented | Yes; doesn't have support for deletion of single machine |
| [Scaleway](https://github.com/scaleway/cluster-api-provider-scaleway/blob/main/docs/scalewaymanagedmachinepool.md) | `ScalewayManagedMachinePool` | Implemented | No |

Providers may support the deletion of single machine pool `Machine` objects. That allows, for example, using `MachineHealthCheck` to remediate machines that became unhealthy.
Copy link
Member

@sbueringer sbueringer Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true today? I thought MHC is not supported yet for MachinePools?

Copy link
Contributor Author

@AndiDog AndiDog Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm living in the world where #11392 is already merged (due to our fork) :), so the feature is live and working in my company. If you don't mind, I'd already document it that way.

Copy link
Member

@sbueringer sbueringer Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just think it's confusing for most of our users if we document something here that only works on your fork. Can we add a small note like "once PR ... is merged"?

Copy link
Contributor Author

@AndiDog AndiDog Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I added a note.

sbueringer
sbueringer reviewed Nov 20, 2025
View reviewed changes
@AndiDog AndiDog force-pushed the mp-machines-support-docs branch from 7d14a43 to 8991d17 Compare November 21, 2025 08:05
@sbueringer
Copy link
Member

sbueringer commented Nov 21, 2025

Thx. I believe this one is still open: #12872 (comment)

@AndiDog AndiDog force-pushed the mp-machines-support-docs branch from 8991d17 to 18dd19e Compare November 25, 2025 22:39
@sbueringer
Copy link
Member

sbueringer commented Nov 26, 2025

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

LGTM label has been added.

Git tree hash: 9aba9093f920c0aebcc466b28bc499486010cc77

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8d7e9d6 into kubernetes-sigs:main Nov 26, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@richardcase richardcase Awaiting requested review from richardcase

@sivchari sivchari Awaiting requested review from sivchari

+2 more reviewers

@mboersma mboersma mboersma left review comments

@joekr joekr joekr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinepool Issues or PRs related to machinepools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

6 participants

@AndiDog @k8s-ci-robot @sbueringer @mboersma @joekr @fabriziopandini