Skip to content

fix: improve-scripts-sorting #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: improve-scripts-sorting #376

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f90d950
fix: improve-scripts-sorting
Oct 12, 2025
ee01003
test: added cases for multiple :
Oct 12, 2025
3484f1b
Update tests/scripts.js
Yaman-kumarsahu Oct 12, 2025
96f8c52
feat(scripts): add recursive nesting logic for script sorting
Yaman-kumarsahu Dec 4, 2025
5a63ff7
Merge branch 'fix/improve-scripts-sorting' of https://github.com/Yama…
Yaman-kumarsahu Dec 4, 2025
927edda
Update index.js
Yaman-kumarsahu Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions tests/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,3 +243,29 @@ test('scripts: group base and colon scripts together, do not split with unrelate
'test-coverage',
])
})

test('scripts: group scripts with multiple colons', (t) => {
const input = {
scripts: {
test: 'run-s test:a test:b',
'test:a': 'foo',
'test:b': 'bar',
'test:a:a': 'foofoo',
'test:a:b': 'foobar',
Comment on lines +257 to +258
Copy link
Collaborator

@fisker fisker Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'test:a:a': 'foofoo',
'test:a:b': 'foobar',
'test:a:a': 'foofoo',
'test:a:b': 'foobar',
'test:a-coverage': 'foobar',

Copy link
Author

@Yaman-kumarsahu Yaman-kumarsahu Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the expected sorted file like this

'test:a',
'test:a-coverage',
'test:a:a',
'test:a:b',

or this

'test:a',
'test:a:a',
'test:a:b',
'test:a-coverage',

Copy link
Author

@Yaman-kumarsahu Yaman-kumarsahu Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want the sorting to be like this

'test:a',
'test:a:a',
'test:a:b',
'test:a-coverage',

we can replace the entire logic with

source = keys.slice().sort((a, b) => 
      a.replace(/:/g, ' ')
      .localeCompare(b.replace(/:/g, ' '), 'en'));

else the current code will sort it in this way

'test:a',
'test:a-coverage',
'test:a:a',
'test:a:b',

'test:b:a': 'barfoo',
'test:b:b': 'barbar',
'test-coverage': 'c8 node --run test',
},
}
const sorted = sortPackageJson(input)
t.deepEqual(Object.keys(sorted.scripts), [
'test',
'test:a',
'test:a:a',
'test:a:b',
'test:b',
'test:b:a',
'test:b:b',
'test-coverage',
])
})