Rename spec_kst_to_all to build-tests and better document process of testing
#112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@generalmimon , is it possible to merge this PR? It greatly simplifies developing process, because you should not remember to make |
Mingun
force-pushed
the
build-scripts
branch
from
b387f0c to
42dfc72
Compare
… generating tests in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the #108 (comment) @generalmimon was not against to removing existing
build-testsscript which is not very useful. On the other hand,spec_kst_to_allscript which is actually useful:-in QWERTY layout)This PR solves both problems by removing the old
build-testsscript and renamingspec_kst_to_allscript tobuild-tests. It also updates documentation, because I find it is difficult to have documentation of how to run tests far away from tests itself in other repository (https://github.com/kaitai-io/kaitai_struct_doc/blob/c87ae4cb447abfb043bcbade1c8d601037469142/kst.adoc).I also described directories that was not described to have the full picture in the Readme.
This PR should be merged together with kaitai-io/kaitai_struct_doc#55 to update mentioned
kst.adoc.