Skip to content

Conversation

@dereknola
Copy link
Member

Proposed Changes

  • Define the immutable klipper-helm image version inside K3s instead of helm-controller. This should reduce the number of steps it takes when maintaining klipper-helm and allow helm-controller bumps to be focused exclusivily on funtionality of that repo, not just one line image bumps.
  • Set the DefaultJobImage to latest. helm-controller#294 is the assocaited helm-controller PR.

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner November 25, 2025 18:14
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.74%. Comparing base (3de0888) to head (a286821).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13258      +/-   ##
==========================================
- Coverage   21.75%   21.74%   -0.01%     
==========================================
  Files         186      186              
  Lines       15284    15284              
==========================================
- Hits         3325     3324       -1     
- Misses      11520    11521       +1     
  Partials      439      439              
Flag Coverage Δ
unittests 21.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants