Skip to content

Conversation

dereknola and others added 10 commits November 21, 2025 17:50
Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit cfcc9ef)
Signed-off-by: Brad Davidson <[email protected]>
* Pass GOOS into Dockerfile.local build args
  Fixes issue with build-windows job not actually building for windows
* Remove `go generate` from package-cli
  We no longer use codegen in this repo
* Fix go:embed path separator on Windows
* Bump hcsshim for containerd 2.1 compat on windows
* Include failing lister in error message
* Bump k3s-io/api and k3s-io/helm-controller for embedded CRD windows path fix

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit ed57fb5)
Signed-off-by: Brad Davidson <[email protected]>
* tunnel: handle pod IP reuse

a valid tunnel/session may be deleted when an IP is reused while a
Complete pod (for example a job) was using that IP but is being gc'ed.

This causes timeouts to webhooks after directDial is attempted because
session was removed.

Solution is to track the owner of the IP and delete the entry only when
the the owner pod is deleted.

Signed-off-by: Julian Vassev <[email protected]>
(cherry picked from commit 9130056)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit f0d5452)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 9806524)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 1037dcb)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit af441c2)
Signed-off-by: Brad Davidson <[email protected]>
It is hidden and undocumented, but also apparently broken.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit f783052)
Signed-off-by: Brad Davidson <[email protected]>
The legacy Docker snapshotter flattens application/vnd.docker.distribution.manifest.v2+json manifests to application/vnd.oci.image.manifest.v1+json when saving. Switching to the containerd snapshotter allows us to keep the original manifest digest when pulling and saving image tarballs.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 74088f5)
Signed-off-by: Brad Davidson <[email protected]>
Remove optional tools from runners to make space available for docker/vagrant

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit f726966)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner November 21, 2025 18:53
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.78%. Comparing base (8dac81b) to head (d7cf5cf).

Files with missing lines Patch % Lines
pkg/agent/containerd/containerd.go 0.00% 75 Missing ⚠️
pkg/etcd/etcd.go 0.00% 12 Missing ⚠️
pkg/spegel/bootstrap.go 0.00% 12 Missing ⚠️
pkg/spegel/spegel.go 0.00% 11 Missing ⚠️
pkg/daemons/control/tunnel.go 0.00% 9 Missing ⚠️
pkg/deploy/stage.go 0.00% 1 Missing ⚠️
pkg/server/context.go 0.00% 1 Missing ⚠️
pkg/util/bindata/embed.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.34   #13251      +/-   ##
================================================
- Coverage         21.92%   21.78%   -0.14%     
================================================
  Files               186      186              
  Lines             15171    15259      +88     
================================================
- Hits               3326     3324       -2     
- Misses            11406    11496      +90     
  Partials            439      439              
Flag Coverage Δ
unittests 21.78% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We do not use any vulnerable code from this project, but we should bump it anyway to pacify scanners

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 3de0888)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 96ed439)
Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants