Skip to content

Conversation

@shuklatushar226
Copy link
Contributor

@shuklatushar226 shuklatushar226 commented Nov 25, 2025

Type of Change

Sending merchant_reference_payment_id as worldpay requires that as reference filed in cpature call (once connector service pr gets merge will update commit)

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

before updation

Screenshot 2025-11-25 at 4 33 09 PM

after updation
Screenshot 2025-11-25 at 3 47 50 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@shuklatushar226 shuklatushar226 requested a review from a team as a code owner November 25, 2025 11:01
@semanticdiff-com
Copy link

semanticdiff-com bot commented Nov 25, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  Cargo.lock Unsupported file format
  crates/external_services/Cargo.toml Unsupported file format
  crates/hyperswitch_interfaces/Cargo.toml Unsupported file format
  crates/router/Cargo.toml Unsupported file format
  crates/router/src/core/unified_connector_service/transformers.rs  0% smaller

@shuklatushar226 shuklatushar226 changed the title fix: Sending merchant_reference_payment_id fix :Sending merchant_reference_payment_id Nov 25, 2025
@shuklatushar226 shuklatushar226 changed the title fix :Sending merchant_reference_payment_id fix: Sending merchant_reference_payment_id Nov 25, 2025
@shuklatushar226 shuklatushar226 linked an issue Nov 25, 2025 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@0aefd07). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...src/core/unified_connector_service/transformers.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10429   +/-   ##
=======================================
  Coverage        ?    6.46%           
=======================================
  Files           ?     1249           
  Lines           ?   310557           
  Branches        ?        0           
=======================================
  Hits            ?    20090           
  Misses          ?   290467           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shuklatushar226 shuklatushar226 requested a review from a team as a code owner November 25, 2025 13:11
@shuklatushar226 shuklatushar226 force-pushed the merchant_reference_payment_id_addition branch from 62e6008 to 89c6130 Compare November 26, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]

3 participants