Add WebHTML Exporter #2246
Draft
Add WebHTML Exporter #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
force-pushed
the
tkp/webhtml
branch
from
6b77a5b to
0b13342
Compare
timkpaine
force-pushed
the
tkp/webhtml
branch
from
43db2b0 to
5a2cb46
Compare
timkpaine
force-pushed
the
tkp/webhtml
branch
from
869cd2a to
4c4ea4c
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: nbprint/nbprint#243
In certain contexts, it can be convenient to render to HTML and render inside a browser, without necessarily converting to PDF. For example, in the linked ticket, I am converting to HTML which is intended to be emailed. Once you hit an email client, there is no more JavaScript, so it would be convenient to have NBconvert render the HTML in a browser and then export the DOM back to HTML, exactly as it does for PDF but resulting in an HTML document instead of a PDF.
One would expect this to have certain side effects when reconstructing inside a JavaScript-enabled environment - but in that case, just use the vanilla HTML exporter.
I've also made the WebPDFExporter inherit from the WebHTMLExporter to minimize code duplication.