refactor: replace toggle with chevron for show variants in Hub #7059
+27
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Show variants" toggle uses a Switch component, but toggle is not the right design pattern here. Toggles are for settings that apply immediately—in this context we're just expanding a layout to show more content. Replaced the Switch with a clickable chevron: - Text "Show variants" with chevron icon to the right - Entire line is clickable, not just the icon - Chevron points down when collapsed, up when expanded - Matches styling of other icons in the row (size 18, text-main-view-fg/50)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
The "Show variants" toggle in Hub uses a Switch component, but toggle is not the right design pattern here. Toggles are for settings that apply immediately—in this context we're just expanding a layout to show more content.
Replaced the Switch with a clickable chevron:
text-main-view-fg/50color)To test it:
Fixes Issues
Self Checklist