Skip to content

Conversation

@stevehipwell
Copy link
Collaborator

This PR replaces #2476.


Before the change?

  • The acceptance tests are complicated and don't all pass

After the change?

  • Acceptance tests have been refactored
    • Fewer tests
    • Simpler test structure
    • Test env setup has been made more granular and documented
  • Acceptance tests have been tested
    • Tests introduced after v6.4.0 haven't been tested
    • Enterprise tests and external user tests have been skipped

Outstanding

  • Re-run all tests locally

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.x version wrap up milestone Nov 24, 2025
@stevehipwell stevehipwell self-assigned this Nov 24, 2025
@github-actions github-actions bot added the Type: Bug Something isn't working as documented label Nov 24, 2025
@stevehipwell stevehipwell force-pushed the fix-integration-tests branch 2 times, most recently from 192aa6b to e5d0594 Compare November 24, 2025 15:29
Copy link
Member

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fantastic! There was a lot, thank you for putting in the 💪 here! I think the only thing that stood out to me is that the workflows / ci jobs need to be updated now that you've change the environment vars - I saw that you updated the contributing doc.

@stevehipwell
Copy link
Collaborator Author

Thanks @nickfloyd I had meant to add that to the description as work to do, as I removed the actual automation changes for a later PR. I also need to do a clean review (not straight after making the changes) to check that nothing got screwed up in the merge.

@stevehipwell stevehipwell marked this pull request as draft November 25, 2025 16:59
@stevehipwell
Copy link
Collaborator Author

@nickfloyd this PR depends on #2946 to be able to configure the automation tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants