Skip to content

add efficient is_empty method to text_editor::Content #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2025
Merged

add efficient is_empty method to text_editor::Content #3117

merged 2 commits into from
Nov 30, 2025

Conversation

@mfreeborn
Copy link
Contributor

@mfreeborn mfreeborn commented Nov 21, 2025 •
edited
Loading

Closes #3105

The unwrap_or could alternatively be a plain unwrap on editor.line(0) because we already matched for line_count == 1. just defer to the inner is_empty method...

@hecrj hecrj added this to the 0.14 milestone Nov 30, 2025
@hecrj hecrj added feature New feature or request widget addition labels Nov 30, 2025
@hecrj hecrj enabled auto-merge November 30, 2025 18:23
hecrj
hecrj approved these changes Nov 30, 2025
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hecrj hecrj merged commit 68eb577 into iced-rs:master Nov 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hecrj hecrj hecrj approved these changes

Assignees

No one assigned

Labels

addition feature New feature or request widget

Projects

None yet

Milestone

0.14

Development

Successfully merging this pull request may close these issues.

text_editor::Content may benefit from an is_empty helper function

2 participants

@mfreeborn @hecrj