Provide a Display handle to graphics::Compositor
#3090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would this be considered a |
hecrj
force-pushed
the
multi-window-fix-iced-rs
branch
from
44ad7eb to
8374c6b
Compare
hecrj
approved these changes
Dec 1, 2025
Member
There was a problem hiding this comment.
Thanks!
However, I have been able to identify the root cause and keep a single shared Context.
The actual issue is that softbuffer::Context expects a HasDisplayHandle and not an actual window.
Therefore, a reference to the first window we use to create the Compositor is stored in the Context and is never dropped when iced_winit closes it.
The solution is to introduce an additional display argument to the Compositor constructors and leverage that instead to create the Context.
hecrj
changed the title
Display handle to graphics::Compositor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3089.