Migrate ha-icon-picker to generic picker #27677
Conversation
| allow-custom-value | ||
| .dataProvider=${ICONS_LOADED ? this._iconProvider : undefined} | ||
| .getItems=${this._getItems} | ||
| .label=${this.label} |
There was a problem hiding this comment.
The new picker label looks out of place next to textfields now
There was a problem hiding this comment.
Original for reference:
the icon is also missing, this is due to the placeholder vs value problem
The main issue for me is the label being outside the textfield now. Maybe an alternative design could be used here?
There was a problem hiding this comment.
I wonder if all labels should be outside the field for consistency. We will have to do it when migrating to web awesome, right?
There was a problem hiding this comment.
Personally not a fan of the label being on the outside, I prefer the way ha-textfield does it, possibly need UX on this. Maybe the default picker design needs another look at
Those using the generic picker currently (with a single option) don't use the label or use the placeholder as the label.
Others using generic picker (single item):
This PR:
timmo001
force-pushed
the
ha-icon-picker-to-generic-picker
branch
from
c6c2d47 to
4d77c2b
Compare
timmo001
added
the
Needs UX
|
Why does the icon naming needs to be prefixed with "mdi:" in the dropdown selector? |
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: