-
Notifications
You must be signed in to change notification settings - Fork 1
DTR-1170: Wiring in LP-2 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
f57addf
16cd9e1
7f80bd1
ae4e23c
732e8e6
1a815aa
0c89c36
a24a9c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright 2025 HM Revenue & Customs | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package viewmodels.agent | ||
|
|
||
| case class AgentLandingViewModel( | ||
| clientName: String, | ||
| employerRef: String, | ||
| utr: Option[String] | ||
| ) |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we create a component simial to:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks Richy, updated now |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ GET /unauthorised/agent controllers. | |
| GET /agent/retrieve-client-list controllers.agent.RetrievingClientController.onPageLoad() | ||
| GET /agent/no-client-list controllers.agent.FailedToRetrieveClientController.onPageLoad() | ||
| GET /agent/no-authorised-clients controllers.agent.NoAuthorisedClientsController.onPageLoad() | ||
| GET /agent/authorised-client-manage-CIS-returns controllers.agent.AgentLandingController.onPageLoad() | ||
| GET /agent/cis-return-dashboard/:uniqueId controllers.agent.AgentLandingController.onPageLoad(uniqueId: String) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Our we ok to expose the uniqueId in the url ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding uniqueId as we need something that distinguish different agent clients. If we don't want uniqueId exposed in url, we can refactor the code to use index as we have all agent clients persisted in Mongo. From the security side, I assume this should be fine. If the agent changes the uniqueId in the url from "123" (authorised) to "456"(unauthorised), we still have the guard in BE to ensure that only client authorised agent can view the landing page for a certain client. So agent would not see client's landing page whose uniqueId is "456". Also uniqueId is not itself PII like utr or NINO or other sensitive info like tax office no. & ref that are actually exposed in the url in the as-is java service. |
||
|
|
||
| GET /agent/file-monthly-cis-returns controllers.agent.ClientListSearchController.onPageLoad() | ||
| POST /agent/file-monthly-cis-returns controllers.agent.ClientListSearchController.onSubmit() | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to check, should the clientName be the schemeName?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so as per confirmation from Laiba before, link for above pic is F6