refactor: let panic arise directly if the provider doesn't implement providers.StateStoreChunkSizeSetter #37942
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…providers.StateStoreChunkSizeSetter
SarahFrench
added
the
no-changelog-needed
radeksimko
approved these changes
Nov 28, 2025
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
Thank you for following-up, just left one minor suggestion
| // don't yet. | ||
| panic("provider does not implement providers.StateStoreChunkSizeSetter interface. This is a bug in Terraform and should be reported.") | ||
| } | ||
| cs := p.provider.(providers.StateStoreChunkSizeSetter) |
Member
There was a problem hiding this comment.
Suggested change
| cs := p.provider.(providers.StateStoreChunkSizeSetter) | |
| // If we reached this point with a non-pluggable backend then that's certainly a bug. | |
| // TODO: Introduce compile-time guard via pluggable interface for the entire provider | |
| cs := p.provider.(providers.StateStoreChunkSizeSetter) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback here: #37899 (comment)
Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry