github/build: Avoid double checkout to prevent errors on upgrade #37941
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
the
no-changelog-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent errors such as
Duplicate header: "Authorization"when the time comes to upgradeactions/checkoutto the latest v6 version. It became clear that without this changehashicorp/actions-set-product-versionwould cause the entire workflow to fail.So this is not a problem yet as we are still pinned to
actions/checkout@v5but the PR is preventative in nature.Aside from addressing the conflict, it also seems like a good practice to avoid checking out the same repository more than once if we do not need to.
See more in https://github.com/hashicorp/releng-support/issues/1030