PSS: Allow pluggable state store configuration to be stored in a plan file and used during an apply operation #37248
+1,592
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
changed the title
Contributor
|
The equivalence tests failed. Please investigate here. |
Contributor
|
The equivalence tests failed. Please investigate here. |
SarahFrench
force-pushed
the
pss/store-pss-in-planfile
branch
from
7b80adb to
a2acc33
Compare
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
1da8373 to
cd0c5b2
Compare
Contributor
|
The equivalence tests failed. Please investigate here. |
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
a42acd7 to
2415a6f
Compare
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
2415a6f to
a5a439f
Compare
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
a5a439f to
1f72760
Compare
Contributor
|
The equivalence tests failed. Please investigate here. |
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
2 times, most recently
from
cb564b4 to
388ced0
Compare
Contributor
|
The equivalence tests failed. Please investigate here. |
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
e3453d7 to
d7cb4cb
Compare
This helps with navigating ambiguity around the word backend. The new name should indicate that the value represents a `backend` block, not a more general interpretation of what a backend is.
…to a lack of data. Don't change it if pluggable state storage is in use.
…sentation of a backend or state_store is empty/unset. Add tests. The alternative approach would be to change the existing `Backend` field in the `Plan` struct to be a pointer. I'm open to either option, but the approach of using an `Empty` method matches existing work in the `workdir` package when inspecting the backend state file, and that seems a similar use-case to inspecting the plan file.
… isn't present; this is valid if the schema contains no attributes or blocks.
…sing that data when creating a plan file.
…ng it to prepare a Local backend that uses the state store
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
2 times, most recently
from
88c80eb to
ef2b038
Compare
SarahFrench
commented
Nov 26, 2025
Comment on lines
-195
to
+197
| Type: "local", | ||
| Config: backendConfigRaw, | ||
| Type: "local", | ||
| Config: backendConfigRaw, | ||
| Workspace: "default", |
Member
Author
There was a problem hiding this comment.
Without this change a lot of existing tests started failing because the Backend 's Empty method returned true, due to the Workspace value being unset.
Error: plan does not have a backend or state_store configuration
…ly isn't valid for `stateStoreConfigState` to be nil I'm about 90% sure that backendConfigState being nil is ok <_<
…rmine if data is present for a state store or backend in a planfile
… file with the expected state_store configuration data
…an file to configure and use a state store
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
88d8f75 to
8a12015
Compare
…e full init-plan-apply workflow
…quired providers, if PSS is in use. See the code comment added in this commit. This addition does not impact an apply command as the missing provider will be detected before this code is executed. However I'm making this change so that the method is still accurate is being able to return a complete list of providers needed by the plan.
…Backend, so the planfile's Backend struct isn't flagged as empty.
… the Backend config are set
…ccessing the Backend field on a Plan struct
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
8a12015 to
c8d17ba
Compare
SarahFrench
changed the title
…te a nil check in calling code.
…or state store config when getting a backend from a planfile
… a plan's description of a backend or state store is complete
…e store is complete when reading or writing a plan file
SarahFrench
force-pushed
the
pss/update-how-operations-use-backend-config-state
branch
from
c8d17ba to
8900e1e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #37246, which began implementing use of pluggable state stores with planfiles.
This PR:
Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry