-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Add support for EKS Provisioned Control Plane #45258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EKS Provisioned Control Plane #45258
Conversation
…ttribute (control_plane_scaling_config)
…ribute (control_plane_scaling_config)
…ig in TestAccEKSClusterDataSource_basicto make tests pass
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
ewbankkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSClusterDataSource_\|TestAccEKSCluster_basic\|TestAccEKSCluster_controlPlaneScalingConfig\|TestAccEKSCluster_Encryption_update' PKG=eks ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/eks/... -v -count 1 -parallel 4 -run=TestAccEKSClusterDataSource_\|TestAccEKSCluster_basic\|TestAccEKSCluster_controlPlaneScalingConfig\|TestAccEKSCluster_Encryption_update -timeout 360m -vet=off
2025/11/26 08:40:30 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/26 08:40:30 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN TestAccEKSClusterDataSource_remoteNetwork
=== PAUSE TestAccEKSClusterDataSource_remoteNetwork
=== RUN TestAccEKSClusterDataSource_controlPlaneScalingConfig
=== PAUSE TestAccEKSClusterDataSource_controlPlaneScalingConfig
=== RUN TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN TestAccEKSCluster_controlPlaneScalingConfig
=== PAUSE TestAccEKSCluster_controlPlaneScalingConfig
=== RUN TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== CONT TestAccEKSClusterDataSource_basic
=== CONT TestAccEKSCluster_basic
=== CONT TestAccEKSCluster_Encryption_update
=== CONT TestAccEKSCluster_controlPlaneScalingConfig
--- PASS: TestAccEKSClusterDataSource_basic (613.41s)
=== CONT TestAccEKSClusterDataSource_remoteNetwork
--- PASS: TestAccEKSCluster_basic (650.33s)
=== CONT TestAccEKSClusterDataSource_controlPlaneScalingConfig
--- PASS: TestAccEKSClusterDataSource_remoteNetwork (632.46s)
=== CONT TestAccEKSClusterDataSource_outpost
cluster_data_source_test.go:86: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.71s)
--- PASS: TestAccEKSClusterDataSource_controlPlaneScalingConfig (606.62s)
--- PASS: TestAccEKSCluster_Encryption_update (1496.23s)
--- PASS: TestAccEKSCluster_controlPlaneScalingConfig (1502.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 1508.075s
johnsonaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
@catlike Thanks for the contribution 🎉 👏. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
No changes to security controls
Description
This PR adds support for EKS Provisioned Control Plane feature.
The
aws_eks_clusterresource and datasource have been updated to the support the newcontrol_plane_scaling_configconfiguration block per the AWS DocumentationDocumentation for both resource and datasource have been added as well.
Relations
Closes #45220
References
Amazon EKS Provisioned Control Plane
Getting started with the Amazon EKS Provisioned Control Plane
type ControlPlaneScalingConfigsupport was added to Terraform AWS Provider via #45227Output from Acceptance Testing
aws_eks_clusterResource Acceptance Testingaws_eks_clusterDatasource Acceptance TestingI did make a small change to
TestAccEKSClusterDataSource_basicto get theresource.TestCheckResourceAttrchecks passing forcompute_configandstorage_configin 66feb68 can revert that change if I have misunderstood the failure.