-
-
Notifications
You must be signed in to change notification settings - Fork 42
WAVE Accessibility - Contrast Ratio Fixes #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@nchanyal I suggest we create and use new entries in
This will allow you to avoid using hard-coded values. Please make this change and also be prepared to discuss your change to the react-router-dom includes at the upcoming dev meeting on Wednesday (2025-11-12). |
|
@ryanfchase Sure, I'll add those changes and update the branch. If you have any particular questions about the changes made to |
ryanfchase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, approved 👍🏼
|
@ryanfchase Thanks. Are there any changes you wanted? The PR says you're requesting a change. |
ryanfchase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, didn't mean to request changes. But thank you for providing screenshots. This PR is good to merge.
geolunalg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Feedback Page
Without annotations
With WAVE annotations:

Create Account Page
Without WAVE annotations:

With WAVE annotations:

Visuals after changes are applied
Feedback Page
Without annotations


With WAVE annotations
Create Account Page
Without annotations

With WAVE annotations
