Skip to content

Conversation

@fyliu
Copy link
Member

@fyliu fyliu commented Apr 10, 2025

What changes did you make?

  • migrated sass @import rules to @use
    • I actually used the sass-migrator package to help with the migration.
      npm install sass-migrator --legacy-peer-deps
      npx sass-migrator module --migrate-deps src/styles/App.scss
      
      After fixing a few initial problems, the tool did the rest.

Why did you make the changes (we will use this info to test)?

  • The @import rule is deprecated and will be removed in a future release

Testing

  • I'm not sure how to get the warnings to display yet
  • But otherwise, the imported variables like background color should still work after this change.

@fyliu
Copy link
Member Author

fyliu commented Apr 17, 2025

@fyliu replicate the conditions again and see if this fix is something that'll allow us to upgrade to a higher version of sass. This fix could be useful if it does.

@fyliu
Copy link
Member Author

fyliu commented Apr 17, 2025

I'd like to save this until after I'm finished dockerizing the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update scss to remove @import rules

4 participants