-
Notifications
You must be signed in to change notification settings - Fork 4.6k
credentials/tls: Splitting host and port of authority header
#8726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
authority header
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8726 +/- ##
==========================================
+ Coverage 83.25% 83.33% +0.07%
==========================================
Files 419 419
Lines 32427 32432 +5
==========================================
+ Hits 26997 27026 +29
+ Misses 4047 4034 -13
+ Partials 1383 1372 -11
🚀 New features to boost your workflow:
|
authority headerauthority header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing tests for authority override are located here:
Could you please add a new test case to the list of successful cases? For the invalid override tests, it would be great if you could refactor them into a table-driven test (similar to the success cases) and include a case for the changes in this PR. This will help avoid code duplication.
Fixes: #8719
Splits the host and port in the HTTP2
:authorityheader inValidateAuthoritybefore callingVerifyHostname. Added test cases to check multiple different types of values possible for:authorityRelease notes: