Add documentation on flipping for diagonal movement in 'First 2D Game" tutorial #11487
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added instructions for handling diagonal movement animations and correcting animation flips based on player input. This fixes "moving sideways and down causes player to flip back on its feet" animation state
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
If these changes are merged the demo project needs to be adjusted to match as well
| .. tabs:: | ||
| .. code-tab:: gdscript GDScript | ||
|
|
||
| if(velocity.x != 0 && velocity.y !=0): # If vertical and horizontal movement keys are pressed |
Member
There was a problem hiding this comment.
Suggested change
| if(velocity.x != 0 && velocity.y !=0): # If vertical and horizontal movement keys are pressed | |
| if velocity.x != 0 and velocity.y != 0: # If the vertical and horizontal movement keys are pressed. |
| $AnimatedSprite2D.flip_v = false | ||
| # See the note below about the following boolean assignment. | ||
| $AnimatedSprite2D.flip_h = velocity.x < 0 | ||
| elif velocity.y != 0 : |
Member
There was a problem hiding this comment.
Suggested change
| elif velocity.y != 0 : | |
| elif velocity.y != 0: |
|
|
||
| .. code-tab:: csharp | ||
|
|
||
| if (velocity.X != 0 && velocity.Y != 0) |
Member
There was a problem hiding this comment.
Suggested change
| if (velocity.X != 0 && velocity.Y != 0) | |
| if (velocity.X != 0 && velocity.Y != 0) // If the vertical and horizontal movement keys are pressed. |
| Play the scene again and check that the animations are correct in each of the | ||
| directions. | ||
|
|
||
|
|
AThousandShips
added
enhancement
area:getting started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions for handling diagonal movement animations and "correcting" animation flips based on player input. This fixes "moving sideways and down causes player to flip back on its feet" animation state.