Fix rapid keypress handling with functional setState #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When multiple arrow key presses arrived in rapid succession (e.g., from terminal automation or fast typing), only a single navigation step would occur instead of multiple steps.
Root Cause
The
useInputhandler was using direct state updates:This caused React's state batching to consolidate multiple rapid keypresses. All keypresses read the same closure value of
selectedIndexbefore React re-rendered, so they all calculated the samenextIndex, resulting in only one move.Solution
Use functional setState to ensure each keypress gets the latest index value:
This ensures each navigation handler reads the most recent state value, allowing rapid keypresses to be processed correctly.
Changes
src/enhanced-select-input/index.tsxto use functional form ofsetSelectedIndexTesting
Tested with terminal automation sending multiple down arrow keys in quick succession - now correctly moves multiple positions instead of just one.
Impact
This is a bug fix that improves the component's responsiveness for: