Skip to content

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Nov 20, 2025

This upgrades our internal eslint config to use v8. Theoretically this is considered a breaking change. Since this is an internal @sentry-internal/* package, we can release this in a non-breaking fashion

With v8 couple of changes came. Some of them are affecting us, which required file changes:

Merge checks

  • Rebased before merge to get the latest changes updated with the new version

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,754 - 9,086 -4%
GET With Sentry 1,752 20% 1,761 -1%
GET With Sentry (error only) 6,196 71% 6,153 +1%
POST Baseline 1,187 - 1,210 -2%
POST With Sentry 569 48% 597 -5%
POST With Sentry (error only) 1,020 86% 1,075 -5%
MYSQL Baseline 3,279 - 3,326 -1%
MYSQL With Sentry 417 13% 493 -15%
MYSQL With Sentry (error only) 2,671 81% 2,708 -1%

View base workflow run

@JPeer264 JPeer264 requested review from Lms24 and s1gr1d November 20, 2025 15:44
@JPeer264 JPeer264 marked this pull request as ready for review November 20, 2025 15:45
@JPeer264 JPeer264 requested a review from a team as a code owner November 20, 2025 15:45
@JPeer264 JPeer264 force-pushed the jp/update-eslint branch 2 times, most recently from 5b9d895 to a6afd58 Compare November 21, 2025 16:12
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically this is considered a breaking change. Since this is an internal @sentry-internal/* package, we can release this in a non-breaking fashion

Before we merge this, let's check in with Electron, Lynx and React-Native SDK maintainers. They all use a 10.x version of @sentry-internal/eslint-config-sdk so we should make sure this change doesn't cause problems for them:

https://github.com/search?type=code&q=%40sentry-internal%2Feslint-config-sdk+owner%3Agetsentry+

I agree btw that we shouldn't have to stick to semver for this internal package. Let's just make sure we break no-one unexpectedly 😅

@JPeer264 JPeer264 force-pushed the jp/update-eslint branch 2 times, most recently from b2ce5c4 to de82cc5 Compare November 26, 2025 09:18
@JPeer264
Copy link
Member Author

@Lms24 I just asked internally and it seems to be ok for the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants