-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Enhance dashboard parameter handling: persist updated values and apply saved parameters #7570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
denisov-vlad
wants to merge
11
commits into
getredash:master
Choose a base branch
from
denisov-vlad:save-dashboard-parameters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−4
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9de81de
Enhance dashboard parameter handling: persist updated values and appl…
denisov-vlad fd3eb53
Fix parameter value persistence: handle undefined values and add erro…
denisov-vlad 35b8970
Enhance parameter persistence: manage pending values during layout ed…
denisov-vlad d25c4ee
Refactor parameter value handling: streamline collection and persiste…
denisov-vlad e67a83a
Implement saveDashboardParameters function and integrate it into Dash…
denisov-vlad d4ec1d3
Refactor dashboard parameter handling: streamline saveDashboardParame…
denisov-vlad 54b27e3
Refactor saveDashboardParameters: simplify parameter value updates an…
denisov-vlad 13d5084
Refactor dashboard parameter handling: improve parameter value update…
denisov-vlad 6bff5be
Refactor DashboardEditControl: update saveDashboardParameters handlin…
denisov-vlad 0ee0134
Refactor saveDashboardParameters: streamline parameter value handling…
denisov-vlad bf61f06
Refactor saveDashboardParameters: update parameter handling to use sa…
denisov-vlad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -210,10 +210,15 @@ Dashboard.prototype.getParametersDefs = function getParametersDefs() { | |
| }); | ||
| } | ||
| }); | ||
| const mergedValues = { | ||
| ..._.mapValues(globalParams, p => p.value), | ||
| ...(this.options.parameterValues || {}), | ||
|
||
| ...queryParams, | ||
denisov-vlad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }; | ||
| const resultingGlobalParams = _.values( | ||
| _.each(globalParams, param => { | ||
| param.setValue(param.value); // apply global param value to all locals | ||
| param.fromUrlParams(queryParams); // try to initialize from url (may do nothing) | ||
| param.setValue(mergedValues[param.name]); // apply merged value | ||
| param.fromUrlParams(queryParams); // allow param-specific parsing logic | ||
| }) | ||
| ); | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.