feat: Implement filter for Facebook lead forms #1426
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a filter to display forms linked to selected Facebook pages.
There was a problem hiding this comment.
Pull Request Overview
This PR implements a filter mechanism for Facebook lead forms to ensure only forms associated with the selected Facebook page are displayed.
Key Changes:
- Added a
facebook_pageevent handler that filters thefacebook_lead_formfield based on the selected page - Introduced query filtering logic to improve user experience by limiting form options to relevant entries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Member
|
@sambhusbabu Add screenshots or screen recording |
shariquerik
changed the title
Author
Add a filter to Desk view Facebook lead form |
NagariaHussain
requested changes
Nov 24, 2025
Comment on lines
+12
to
+13
| // added a filter to show form only linked to pages | ||
| facebook_page(frm) { |
Collaborator
There was a problem hiding this comment.
Let's add an early exit if frm.doc.facebook_page is empty/falsy. What happens when we clear the Facebook page field and then input in the form field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a filter to display forms linked to selected Facebook pages.