C++ example for playback over WebSocket #770
Conversation
eloff
left a comment
eloff
left a comment
There was a problem hiding this comment.
Again, just minor feedback
| // illustration, this example generates a fixed buffer of example data in-memory. | ||
| class DataPlayer { | ||
| public: | ||
| explicit DataPlayer(size_t num_timesteps, foxglove::RawChannel&& channel) |
There was a problem hiding this comment.
Don't think you need explicit here
There was a problem hiding this comment.
Good catch, this was left over from when the channel lived outside the class
|
|
||
| void process() { | ||
| if (!server_) { | ||
| throw std::runtime_error("Tried to spin with uninitialized server"); |
There was a problem hiding this comment.
Run or process might be better words than spin here
There was a problem hiding this comment.
I decided to use tick to show that this is being invoked by an outer execution loop
|
|
||
| // Internal variables for orchestrating playback. In addition to accessing data_, these are are | ||
| // used to generate a foxglove::PlaybackState to send to the Foxglove player. | ||
| std::atomic<size_t> current_playback_index_ = 0; |
There was a problem hiding this comment.
Using multiple atomics like this leads to all kinds of strange race conditions, seeing partial or out of order updates.
As an example I'd be more confortable if it was a mutex.
Maybe nothing bad happens here, but we should set a conservative example.
ericmlujan
force-pushed
the
eric/cpp-player-example
branch
from
0de50b9 to
4317d2a
Compare
3 participants
Changelog
None
Docs
In-line documentation provided
Description
Annotated C++ example using the functionality introduced in #746.
Fixes: FLE-142