chore: use ci for prs #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for agitated-mahavira-26f8f9 canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Open
Contributor
|
@Uzlopak I've added a commit to make the tests work again. If you think it doesn't make any sense, feel free to revert |
Uzlopak
commented
Nov 24, 2025
Uzlopak
commented
Nov 24, 2025
Signed-off-by: Aras Abbasi <[email protected]>
Signed-off-by: Aras Abbasi <[email protected]>
gurgunday
approved these changes
Nov 24, 2025
Uzlopak
commented
Nov 24, 2025
Signed-off-by: Aras Abbasi <[email protected]>
Uzlopak
force-pushed
the
use-ci-for-pr
branch
2 times, most recently
from
4f10f2c to
5966193
Compare
ilteoood
reviewed
Nov 25, 2025
Comment on lines
+131
to
+133
| const fixWin32Path = process.platform === 'win32' | ||
| ? (filePath) => new URL(fileUrl(filePath)) | ||
| : (filePath) => filePath |
Contributor
There was a problem hiding this comment.
shouldn't this be extracted outside of this function?
We are re-creating the fix function on every invocation of loadBundle, but I don't think that the platform will change once is executed the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct