Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/__tests__/test-project/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion packages/core/src/services/PackageManagerService.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { existsSync, writeFileSync } from "fs";
import { existsSync, unlinkSync, writeFileSync } from "fs";
import { safeExec } from "../tests/cli";
import { createProjectForTestFile, deleteTestProject } from "../tests/test-project";
import { PackageJson } from "./PackageJson";
Expand Down Expand Up @@ -33,6 +33,15 @@ describe("PackageManagerService", () => {
});

it("should throws an error when no package manager is detectable", () => {
// Remove all lock files to ensure no package manager is detected
const lockFiles = ['package-lock.json', 'yarn.lock', 'pnpm-lock.yaml'];
lockFiles.forEach(lockFile => {
const lockFilePath = `${testProjectDir}/${lockFile}`;
if (existsSync(lockFilePath)) {
unlinkSync(lockFilePath);
}
});

expect(() => {
PackageManagerService.detectPackageManager(testProjectDir);
}).toThrow(`Could not detect package manager in directory: ${testProjectDir}. No lock file found.`);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/services/PackageManagerService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class PackageManagerService {
static async isPackageInstalled(packageName: string, dirPath: string): Promise<boolean> {
const packageManager = PackageManagerService.detectPackageManager(dirPath);

const args: string[] = [packageManager, "list", "--depth=1", "--json"];
let args: string[] = [packageManager, "list", "--depth=1", "--json"];

switch (packageManager) {
case PackageManagerType.yarn:
Expand Down
4 changes: 4 additions & 0 deletions packages/react/__tests__/test-project/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading