Skip to content

fix(maker-dmg): Prevent conflict between parallel makers #3519 #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(maker-dmg): Prevent conflict between parallel makers #3519 #3741

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f7ad0b
fix: Prevent conflict between parallel makers #3519
lockiechen Oct 21, 2024
3983c73
fix: Prevent conflict between parallel makers #3519
lockiechen Oct 21, 2024
b15aef2
fix: Prevent conflict between parallel makers #3519
lockiechen Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/maker/dmg/src/MakerDMG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ export default class MakerDMG extends MakerBase<MakerDMGConfig> {

async make({ dir, makeDir, appName, packageJSON, targetArch }: MakerOptions): Promise<string[]> {
const { createDMG } = require('electron-installer-dmg');

const outPath = path.resolve(makeDir, `${this.config.name || appName}.dmg`);
const dmgName = `${this.config.name || appName}_${targetArch}.dmg`
const outPath = path.resolve(makeDir, dmgName);
const forgeDefaultOutPath = path.resolve(makeDir, `${appName}-${packageJSON.version}-${targetArch}.dmg`);

await this.ensureFile(outPath);
const dmgConfig = {
overwrite: true,
name: appName,
...this.config,
name: dmgName,
appPath: path.resolve(dir, `${appName}.app`),
out: path.dirname(outPath),
};
Expand Down