Fix traffic counter for transfer.mod in #1844
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: https://github.com/michaelortmann/
Patch by: https://github.com/michaelortmann/
Fixes:
One-line summary:
Fix traffic counter for transfer.mod in
Additional description (if needed):
Test cases demonstrating functionality (if applicable):
On the Bot:
.chattr testuser +xOn the shell of testuser:
which means testfile is 2.55 MB
on the irc client of testuser:
/dcc send Bot testfileBefore:
After:
This is not only a fix of traffic counting. if you create / send a file to the bot, that does not contain a NULL-byte, strlen(buf) would over read:
> valgrind --track-origins=yes ./eggdrop -t BotB.conf