Skip to content

Ignore blank color defaults in ColorsAndFontsPreferencePage #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasmelcher merged 1 commit into from
Dec 4, 2025
Merged

Ignore blank color defaults in ColorsAndFontsPreferencePage #3561

tobiasmelcher merged 1 commit into from
Dec 4, 2025
+21 −7

Conversation

@tobiasmelcher
Copy link
Contributor

@tobiasmelcher tobiasmelcher commented Nov 28, 2025

Fixes #3559

@tobiasmelcher tobiasmelcher mentioned this pull request Nov 28, 2025
Merged
@Phillipus
Copy link
Contributor

Phillipus commented Nov 28, 2025

I tested this on Windows 11. It does fix 99% of the problem. But Viewpart tabs are blue:

Image 001 Image 002

@tobiasmelcher
Copy link
Contributor Author

tobiasmelcher commented Nov 28, 2025

I tested this on Windows 11. It does fix 99% of the problem. But Viewpart tabs are blue:

Image 001 Image 002

Yes, I have also seen this behavior. I currently don't see why the Colors of the Tabs are handled in a special case ...
I don't want to add an if for this specific color.

@Phillipus
Copy link
Contributor

Phillipus commented Nov 28, 2025 •
edited
Loading

When "Reset Defaults" on Windows Light theme is pressed these values are written to .metadata\.plugins\org.eclipse.core.runtime\.settings\org.eclipse.ui.workbench.prefs:

org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_END=191,205,219
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_START=216,225,233
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_TEXT_COLOR=0,0,0
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_BG_END=153,180,209
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_BG_START=229,236,243
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_INNER_KEYLINE_COLOR=255,255,255
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_OUTER_KEYLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_OUTLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_TEXT_COLOR=0,0,0
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_UNSELECTED_TABS_COLOR_END=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_UNSELECTED_TABS_COLOR_START=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_BG_END=240,240,240
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_BG_START=255,255,255
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_INNER_KEYLINE_COLOR=255,255,255
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_OUTER_KEYLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_OUTLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_TEXT_COLOR=0,0,0
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_UNSELECTED_TABS_COLOR_END=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_UNSELECTED_TABS_COLOR_START=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.SECONDARY_BACKGROUND=248,248,248

That's strange because some of those differ from the values defined in the theme CSS files.

For example, I can't see where these values are taken from:

org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_END=191,205,219
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_START=216,225,233

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 9m 41s ⏱️ - 5m 49s
 8 236 tests ±0   7 988 ✅ +1  248 💤 ±0  0 ❌  - 1 
23 628 runs  ±0  22 837 ✅ +1  791 💤 ±0  0 ❌  - 1 

Results for commit b5950cd. ± Comparison against base commit 7829422.

♻️ This comment has been updated with latest results.

@tobiasmelcher tobiasmelcher force-pushed the ignore_blank_default_colors branch from afd3306 to b9f7871 Compare November 28, 2025 15:34
@tobiasmelcher
Copy link
Contributor Author

tobiasmelcher commented Nov 28, 2025

When "Reset Defaults" on Windows Light theme is pressed these values are written to .metadata\.plugins\org.eclipse.core.runtime\.settings\org.eclipse.ui.workbench.prefs:

org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_END=191,205,219
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_START=216,225,233
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_TEXT_COLOR=0,0,0
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_BG_END=153,180,209
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_BG_START=229,236,243
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_INNER_KEYLINE_COLOR=255,255,255
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_OUTER_KEYLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_OUTLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_TAB_TEXT_COLOR=0,0,0
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_UNSELECTED_TABS_COLOR_END=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_UNSELECTED_TABS_COLOR_START=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_BG_END=240,240,240
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_BG_START=255,255,255
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_INNER_KEYLINE_COLOR=255,255,255
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_OUTER_KEYLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_OUTLINE_COLOR=229,229,229
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_TAB_TEXT_COLOR=0,0,0
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_UNSELECTED_TABS_COLOR_END=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.INACTIVE_UNSELECTED_TABS_COLOR_START=248,248,248
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.SECONDARY_BACKGROUND=248,248,248

That's strange because some of those differ from the values defined in the theme CSS files.

For example, I can't see where these values are taken from:

org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_END=191,205,219
org.eclipse.e4.ui.css.theme.e4_default.org.eclipse.ui.workbench.ACTIVE_NOFOCUS_TAB_BG_START=216,225,233

I have updated the pull request, unfortunately with an additional if which I wanted to avoid. @Phillipus could you please test again with the latest upload? Are the colors now reset as expected? Thanks so much.

@Phillipus
Copy link
Contributor

Phillipus commented Nov 28, 2025

I have updated the pull request, unfortunately with an additional if which I wanted to avoid. @Phillipus could you please test again with the latest upload? Are the colors now reset as expected? Thanks so much.

Yep, that's fixed it. Dark theme is also OK. Thanks!

@vogella vogella force-pushed the ignore_blank_default_colors branch from b9f7871 to b5950cd Compare December 4, 2025 13:38
@vogella
Copy link
Contributor

vogella commented Dec 4, 2025

Freeze period is over, @tobias-melcher please merge if this PR is finished.

(thanks for fixing this)

@tobiasmelcher tobiasmelcher merged commit 02fc196 into eclipse-platform:master Dec 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeckerWdf BeckerWdf BeckerWdf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macOS dark theme color issues in 2025-12 M3

5 participants

@tobiasmelcher @Phillipus @vogella @BeckerWdf @tobias-melcher