-
Notifications
You must be signed in to change notification settings - Fork 228
Fix and enable MediaRulesTest:testMediaRule #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f28b7a to
85631cd
Compare
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Outdated
Show resolved
Hide resolved
|
The failure of |
85631cd to
6ecedac
Compare
6ecedac to
cbfc743
Compare
fedejeanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better. You could add a use case that checks that the order doesn't play a role and extract a private method to improve readability
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Show resolved
Hide resolved
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Outdated
Show resolved
Hide resolved
43a69c6 to
2b3badb
Compare
bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/ButtonElement.java
Outdated
Show resolved
Hide resolved
...eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/MediaRulesTest.java
Show resolved
Hide resolved
tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CTabItemTest.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CTabItemTest.java
Outdated
Show resolved
Hide resolved
8ef69d9 to
7e90873
Compare
fedejeanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testSelectPseudo is failing. Please investigate and fix or undo changes in it
0d7e0c5 to
efcd7e3
Compare
efcd7e3 to
0b1e109
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
HeikoKlare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reenabled test is properly and successfully executed in the CI runs.
@fedejeanne any concerns remaining on your side?
No concerns |
1c8a57a to
849dea2
Compare
849dea2 to
1380617
Compare
Enabled some disabled tests which aren't in broken state anymore and fixed other disabled tests.
eclipse-platform/eclipse.platform#525
In the MediaRulesTest class, we test for if a CSS rule with @media tag is considered on parsing. Ideally we want the rule to be ignored.
Suppose we have a CSS string like:
@media screen, print {
BODY { background-color: red }
}
In the previous version of the test (which was disabled), it was expected that the rule "BODY { background-color: red }" under @media tag would be completely ignored. But now the behaviour has changed. It seems like the rules under @media are loaded indeed on parsing but the attributes are ignored, i.e. it looks like "BODY { }".
However, this behaviour doesn't have any side effect since a rule with no attributes neither change anything nor resets anything.