Skip to content

Conversation

@amartya4256
Copy link
Contributor

@amartya4256 amartya4256 commented Dec 7, 2023

Enabled some disabled tests which aren't in broken state anymore and fixed other disabled tests.
eclipse-platform/eclipse.platform#525

In the MediaRulesTest class, we test for if a CSS rule with @media tag is considered on parsing. Ideally we want the rule to be ignored.
Suppose we have a CSS string like:
@media screen, print {
BODY { background-color: red }
}
In the previous version of the test (which was disabled), it was expected that the rule "BODY { background-color: red }" under @media tag would be completely ignored. But now the behaviour has changed. It seems like the rules under @media are loaded indeed on parsing but the attributes are ignored, i.e. it looks like "BODY { }".

However, this behaviour doesn't have any side effect since a rule with no attributes neither change anything nor resets anything.

@amartya4256 amartya4256 force-pushed the enable_tests branch 4 times, most recently from 3f28b7a to 85631cd Compare December 8, 2023 08:27
@fedejeanne
Copy link
Member

The failure of org.eclipse.ui.tests.progress.ProgressViewTests.testItemOrder might be unrelated to your changes (and it probably is). Please look for any existing issue on that (and, if there is none, please create one) and mention it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 25m 35s ⏱️ + 12m 35s
 8 236 tests ±0   7 988 ✅ +1  248 💤  - 1  0 ❌ ±0 
23 628 runs  ±0  22 837 ✅ +3  791 💤  - 3  0 ❌ ±0 

Results for commit 1380617. ± Comparison against base commit 1cffef2.

♻️ This comment has been updated with latest results.

Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. You could add a use case that checks that the order doesn't play a role and extract a private method to improve readability

@amartya4256 amartya4256 force-pushed the enable_tests branch 2 times, most recently from 43a69c6 to 2b3badb Compare December 11, 2023 12:37
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testSelectPseudo is failing. Please investigate and fix or undo changes in it

@amartya4256 amartya4256 force-pushed the enable_tests branch 2 times, most recently from 0d7e0c5 to efcd7e3 Compare November 19, 2025 08:34
@amartya4256 amartya4256 linked an issue Nov 19, 2025 that may be closed by this pull request
@HeikoKlare HeikoKlare changed the title Enable tests Fix and enable MediaRulesTest:testMediaRule Dec 1, 2025
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2cd87e28fb48ee0e2ab765fcbfb48611bbea276c Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 1 Dec 2025 09:11:37 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF b/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
index 83d8ecbfed..f5b9ad082d 100644
--- a/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.ui.tests.css.core
-Bundle-Version: 1.302.700.qualifier
+Bundle-Version: 1.302.800.qualifier
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.swt,
  org.eclipse.e4.ui.css.core,
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reenabled test is properly and successfully executed in the CI runs.

@fedejeanne any concerns remaining on your side?

@fedejeanne
Copy link
Member

@fedejeanne any concerns remaining on your side?

No concerns

@HeikoKlare HeikoKlare merged commit d1713be into eclipse-platform:master Dec 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable CSS tests

5 participants