Skip to content

Enable retry mechanism is Fluent Crashes #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2025
+53 −4
Merged

Enable retry mechanism is Fluent Crashes #11284

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c84e07
Adding retry mechanism in DwmExtendFrameIntoClientArea
himgoyalmicro Nov 19, 2025
587f7a3
Adding Log Statement
himgoyalmicro Nov 24, 2025
da49874
Add Containment (#11285)
harshit7962 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Standard/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using System.Runtime.InteropServices;
using System.Runtime.InteropServices.ComTypes;
using System.Text;
using System.Threading;
using Microsoft.Win32.SafeHandles;

// Some COM interfaces and Win32 structures are already declared in the framework.
Expand Down Expand Up @@ -2501,8 +2502,8 @@ public static IntPtr CreateWindowEx(
[DllImport("dwmapi.dll", PreserveSig = false)]
public static extern int DwmGetWindowAttribute(IntPtr hWnd, DWMWA dwAttributeToGet, ref int pvAttributeValue, int cbAttribute);

[DllImport("dwmapi.dll", PreserveSig = false)]
public static extern int DwmExtendFrameIntoClientArea(IntPtr hwnd, ref MARGINS pMarInset);
[DllImport("dwmapi.dll", EntryPoint = "DwmExtendFrameIntoClientArea", PreserveSig = false)]
private static extern int _DwmExtendFrameIntoClientArea(IntPtr hwnd, ref MARGINS pMarInset);

[DllImport("dwmapi.dll", EntryPoint = "DwmIsCompositionEnabled", PreserveSig = false)]
[return: MarshalAs(UnmanagedType.Bool)]
Expand All @@ -2511,6 +2512,32 @@ public static IntPtr CreateWindowEx(
[DllImport("dwmapi.dll", EntryPoint = "DwmGetColorizationColor", PreserveSig = true)]
private static extern HRESULT _DwmGetColorizationColor(out uint pcrColorization, [Out, MarshalAs(UnmanagedType.Bool)] out bool pfOpaqueBlend);

public static int DwmExtendFrameIntoClientArea(IntPtr hwnd, ref MARGINS pMarInset)
{
int retryCount = 2;
while(retryCount > 0)
{
try
{
return _DwmExtendFrameIntoClientArea(hwnd, ref pMarInset);
}
catch (COMException ex)
{
// DWM composition may not be available or the operation failed
// Return the error code rather than crashing the application
retryCount--;
if(retryCount == 0)
{
return ex.HResult;
}
System.Diagnostics.Trace.WriteLine($"DwmExtendFrameIntoClientArea: retrying after COMException (HResult={ex.HResult})");
Thread.Sleep(100);
}
}

return 0;
}

public static bool DwmGetColorizationColor(out uint pcrColorization, out bool pfOpaqueBlend)
{
// Make this call safe to make on downlevel OSes...
Expand Down
Loading