Skip to content

JIT: Skip GC info for trivial async calls for x86 #121941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

JIT: Skip GC info for trivial async calls for x86 #121941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e6d95
JIT: Skip GC info for trivial async calls for x86
jakobbotsch Nov 24, 2025
c1dd57b
Negate the mask
jakobbotsch Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coreclr/jit/emit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10372,9 +10372,10 @@ void emitter::emitStackPopLargeStk(BYTE* addr, bool isCall, unsigned char callIn
assert(regMaskTP::FromIntRegSet(SingleTypeRegSet(byrefRegs << REG_INT_FIRST)) == emitThisByrefRegs);

#ifdef JIT32_GCENCODER
// x86 does not report GC refs/byrefs in return registers at call sites
gcrefRegs &= ~(1u << (REG_INTRET - REG_INT_FIRST));
byrefRegs &= ~(1u << (REG_INTRET - REG_INT_FIRST));
// x86 only reports GC refs/byrefs in callee saves at call sites -- no return registers.
unsigned reportedRegs = (RBM_INT_CALLEE_SAVED | RBM_EBP).GetIntRegSet() >> REG_INT_FIRST;
gcrefRegs &= reportedRegs;
byrefRegs &= reportedRegs;

// For the general encoder, we always have to record calls, so we don't take this early return. /* Are there any
// args to pop at this call site?
Expand Down
Loading