Skip to content

Conversation

@abhiramch018
Copy link

@abhiramch018 abhiramch018 commented Nov 26, 2025

This PR updates the MSTEST0018 analyzer documentation to remove the outdated requirement that members referenced in [DynamicData] must be public.

Changes made

Removed “should be public” from both the data source and display name member rule lists.

Aligned the rule description with the current MSTest v3 behavior.

Reason for change
MSTest v3 no longer requires [DynamicData] members to be public.
The documentation previously reflected the older MSTest v2 behavior, which is now obsolete.

Related issue
Fixes #49663


Internal previews

📄 File 🔗 Preview link
docs/core/testing/mstest-analyzers/mstest0018.md MSTEST0018: DynamicData should be valid

@abhiramch018 abhiramch018 requested review from a team and IEvangelist as code owners November 26, 2025 08:54
@dotnetrepoman dotnetrepoman bot added this to the November 2025 milestone Nov 26, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSTEST0018 documentation mentions public requirement which is not correct any more

1 participant