-
Notifications
You must be signed in to change notification settings - Fork 606
ci: use docker github builder to build bin image and binaries #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3aaccb8 to
e4c8478
Compare
.github/workflows/build.yml
Outdated
| meta-images: | | ||
| ${{ env.REPO_SLUG }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't use env with reusable workflows 😞
https://github.com/docker/buildx/actions/runs/19329818722
Seems we need an extra job just to set it as an output: https://github.com/orgs/community/discussions/26671 😑
🙃 https://github.com/orgs/community/discussions/26671#discussioncomment-4295807
96dacaf to
acc33b1
Compare
|
GitHub hosted runner doesn't have enough space to build our image: https://github.com/docker/buildx/actions/runs/19330419315/job/55292703625#step:8:521 Hence why we free up disk space currently (see #3040) For our reusable workflow, one way to fix it would be to distribute build across runners: docker/github-builder-experimental#2 |
acc33b1 to
969b0cb
Compare
|
Switch reusable workflow ref to |
e491c64 to
fe39cf7
Compare
fe39cf7 to
a657c7e
Compare
|
Pushed extra commit to also build our binaries with our reusable workflow. |
2fb93c7 to
d696d03
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
d696d03 to
9a64ed8
Compare
docker/github-builder-experimental#21