Restored search hotkey for desktop. #2355
Conversation
sarahboyce
force-pushed
the
fix-search-hot-key-desktop
branch
2 times, most recently
from
549b303 to
9d9dbf6
Compare
adamzap
left a comment
adamzap
left a comment
There was a problem hiding this comment.
I'm still catching up on recent PRs...it looks like we have two elements with the same ID on the page now. I wonder if there's a way to achieve the same behavior with a single element and responsive styling. Do you or others think this is worth pursuing?
I originally tried doing this but found it challenging. The search bar duplication aligns with the light/dark mode toggle duplication and show/hide behavior, aligning to that was easier to acheive given the existing html structure |
sarahboyce
force-pushed
the
fix-search-hot-key-desktop
branch
3 times, most recently
from
7e511ca to
b458667
Compare
| self.assertTrue(is_focused) | ||
| page.close() | ||
|
|
||
| def test_search_ctrl_k_hotkey_mobile(self): |
There was a problem hiding this comment.
I think you need to set an explicit user agent on the two hotkey tests. I'm getting failures because I'm running them locally on a Mac.
| STATIC = djangoproject/static | ||
|
|
||
| ci: compilemessages test | ||
| ci: compilemessages collectstatics test |
There was a problem hiding this comment.
Is this needed because of the new JavaScript tests?
There was a problem hiding this comment.
Yes 👍
(I think this also mostly fixes #1831 but still need the tests to use the production STORAGES setting, can have someone check if that can be pulled into the common settings file 🤔)
sarahboyce
force-pushed
the
fix-search-hot-key-desktop
branch
from
9293dd0 to
c59d0cd
Compare
3 participants
Fixes #2349
I also added playwright to have a way to test JavaScript (might be controversial and can remove if wanted)