Made the language and documentation version switcher accessible by keyboard. #2347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
force-pushed
the
language-switcher-accessibility
branch
2 times, most recently
from
7431bbc to
74b62df
Compare
SaptakS
reviewed
Nov 24, 2025
Contributor
SaptakS
left a comment
SaptakS
left a comment
There was a problem hiding this comment.
I haven't tested the styling, but left some comments on the markup. Let me know if you have any thoughts.
sarahboyce
force-pushed
the
language-switcher-accessibility
branch
from
74b62df to
61c8772
Compare
Contributor
Author
|
Lovely suggestions thank you! I've tried to incorporate each of them 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1955
Note that I removed the titles as I don't believe they are worth it