Improve docker db settings #2311
Open
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
force-pushed
the
improve-docker-db-settings
branch
from
fed35b0 to
bad8373
Compare
* We don't benefit from having separate definitions * Pycharm was marking this code block with "replace dictionary creation" recommendation
These are provided by docker-compose.yml file, no default is needed.
ulgens
force-pushed
the
improve-docker-db-settings
branch
from
bad8373 to
a6f4764
Compare
pauloxnet
approved these changes
Nov 24, 2025
| - TRAC_DATABASE=code.djangoproject | ||
| - TRAC_USER=code.djangoproject | ||
| # "code.djangoproject" value is hardcoded in trac.sql, no need to pass it via env vars | ||
| # - TRAC_USER=code.djangoproject |
Member
There was a problem hiding this comment.
Is trac.sql the only place where code.djangoproject is used?
| "HOST": os.environ.get("SQL_HOST"), | ||
| "PORT": os.environ.get("SQL_PORT"), | ||
| } | ||
| "ENGINE": os.environ["SQL_ENGINE"], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup in
settings/docker.pyfile. Details can be found in commit messages.