feat(frontend): Add NFT collections refresh button to header #10632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
AntonioVentilii
December 1, 2025 12:13
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an on-demand refresh button for NFT collections to the Assets header, addressing performance concerns with automatic collection refreshing. The button emits a custom event with a callback mechanism to manage loading states.
- Created
RefreshCollectionsButtoncomponent with loading state management - Updated
LoaderCollectionsto handle reload events with callback support - Enhanced type safety by properly typing the
oisyReloadCollectionscustom event
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/lib/components/nfts/RefreshCollectionsButton.svelte | New button component that emits reload event and manages loading state via callback |
| src/frontend/src/lib/components/tokens/Assets.svelte | Adds refresh button to NFT tab header alongside sort and settings menus |
| src/frontend/src/lib/components/loaders/LoaderCollections.svelte | Updated to accept callback in reload event and invoke it after completion |
| src/frontend/src/lib/types/custom-events.ts | New interface defining the callback structure for reload events |
| src/frontend/src/custom-events.d.ts | Updated type declarations to use proper typing instead of any |
| src/frontend/src/tests/lib/components/nfts/RefreshCollectionsButton.spec.ts | Comprehensive test coverage for the new button component |
| src/frontend/src/tests/lib/components/loaders/LoaderCollections.spec.ts | Updated tests to verify callback invocation after reload completes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/frontend/src/lib/components/nfts/RefreshCollectionsButton.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/nfts/RefreshCollectionsButton.svelte
Outdated
Show resolved
Hide resolved
…svelte Co-authored-by: Copilot <[email protected]>
roman-nazaruk
approved these changes
Dec 1, 2025
AntonioVentilii
deleted the
feat-frontend/Add-NFT-collections-refresh-button-to-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The EXT NFT collections are refreshed based on a curated list of EXT tokens. However, since they are a lot, it does not really make sense to keep refreshing them: it will only slow down the UI.
So, we will refresh it on demand.
In this PR we create the button to refresh collections and add it into the
Assetsheader.Note that the button will be loading/disabled, until the callback (called after the refresh is finished) is called.
Changes
RefreshCollectionsButtonto emit the eventoisyReloadCollectionswith a callback for when the event is finished.oisyReloadCollectionsto accept a callback.Tests
Practical test:
Screen.Recording.2025-11-28.at.23.29.55.mov