feat(frontend): IC send review accepts NFTs #10629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds NFT support to the IcSendReview component to prepare for EXT token integration, mirroring the existing implementation in EthSendReview. The changes enable the component to handle both token and NFT transfers by conditionally validating amounts based on whether an NFT is being sent.
Key changes:
- Added
nftprop to theIcSendReviewcomponent Props interface - Updated validation logic to skip amount validation when sending NFTs
- Passed
nftprop through to the underlyingSendReviewcomponent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roman-nazaruk
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Copying what was done in
EthSendReview, we add the possibility to have NFT in componentIcSendReview, to prepare for EXT tokens.