feat(frontend): Service to call the transfer method of EXT token canister
#10627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new API service function to call the transfer method of the EXT v2 token canister, enabling NFT transfers within a collection. The implementation follows existing patterns in the codebase for handling identity validation and parameter ordering.
Key changes:
- Implements the
transferAPI function that wraps the canister'stransfermethod - Adds comprehensive test coverage including success and error cases
- Improves JSDoc consistency by reordering parameters in existing documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/frontend/src/icp/api/ext-v2-token.api.ts | Adds the transfer function to enable NFT transfers; also fixes JSDoc parameter ordering in balance and getTokensByOwner |
| src/frontend/src/tests/icp/api/ext-v2-token.api.spec.ts | Adds test suite for the new transfer function covering success and nullish identity error cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roman-nazaruk
approved these changes
Dec 1, 2025
AntonioVentilii
deleted the
feat-frontend/Service-to-call-the-transfer-method-of-EXT-token-canister
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Like the other methods, we create an API service to call method
transferofExtV2TokenCanister.